Re: [PATCH 18/16] implement posix O_SYNC and O_DSYNC semantics

[Christoph Hellwig]

On Thu, Sep 10, 2009 at 04:38:40PM -0400, Trond Myklebust wrote:
> >  	return vfs_fsync_range(file, file->f_path.dentry, pos,
> > -			       pos + count - 1, 1);
> > +			       pos + count - 1,
> > +			       (file->f_flags & O_SYNC) ? 1 : 0);
> >  }
> >  EXPORT_SYMBOL(generic_write_sync);
> >  
> Shouldn't this be testing for
> 
>    file->f_flags & __O_SYNC
> 
> ?

Doesn't matter, we check early in the open path that __O_SYNC is only
set together with O_SYNC.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/