Re: [PATCH 04/10] s390: Convert BUG() to use unreachable()

From: Martin Schwidefsky
Date: Fri Sep 11 2009 - 08:18:35 EST


On Thu, 10 Sep 2009 16:56:45 -0700
David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote:

> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: David Daney <ddaney@xxxxxxxxxxxxxxxxxx>
> CC: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> CC: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> CC: linux390@xxxxxxxxxx
> CC: linux-s390@xxxxxxxxxxxxxxx
> ---
> arch/s390/include/asm/bug.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/s390/include/asm/bug.h b/arch/s390/include/asm/bug.h
> index 7efd0ab..efb74fd 100644
> --- a/arch/s390/include/asm/bug.h
> +++ b/arch/s390/include/asm/bug.h
> @@ -49,7 +49,7 @@
>
> #define BUG() do { \
> __EMIT_BUG(0); \
> - for (;;); \
> + unreachable(); \
> } while (0)
>
> #define WARN_ON(x) ({ \

That seems simple enough ;-)

Acked-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/