Re: [RFC][v6][PATCH 0/9] clone_with_pids() syscall

From: Sukadev Bhattiprolu
Date: Fri Sep 11 2009 - 12:42:17 EST


| Also, if you're passing a struct, why not put nr_pids in there, and
| replace clone_pid_struct with a simple array? That would give us
|
| struct clone_struct {
| u64 flags;
| u64 child_stack;
| u32 child_tid;
| u32 parent_tid;
| u32 nr_pids;
| u32 reserved1;
| u64 reserved2;
| };
|
| int clone2(struct clone_struct *cs, pid_t *pids);

My only concern with this approach was the extra copy_from_user() in the
common case (i.e when not using the extended features). I assume the
overhead of copy_from_user() is small enough to be ignored ?

Thanks,

Sukadev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/