Re: [PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

[Robin Getz]

On Tue 15 Sep 2009 07:19, Mike Frysinger pondered:
> On Tue, Sep 15, 2009 at 02:20, Dmitry Torokhov wrote:
> > On Mon, Sep 14, 2009 at 06:18:39PM -0400, Mike Frysinger wrote:
> >> +static int __devexit adp5588_remove(struct i2c_client *client)
> >> +{
> >> + Â Â struct adp5588_kpad *kpad = dev_get_drvdata(&client->dev);
> >> +
> >> + Â Â adp5588_write(client, CFG, 0);
> >> + Â Â free_irq(client->irq, kpad);
> >
> > cancel_work_sync() is missing. Could you try the updated version below?
> 
> i dont think i have any adp5588 hardware.  Robin: do we have any in
> Norwood?  otherwise, it'll have to wait for Michael to get back to
> double check.

I think Michael has the only hardware at the moment.

He will be back on Monday.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/