Re: [patch 44/45] PCI: Unhide the SMBus on the Compaq Evo D510 USDT

[Jean Delvare]

Hi Greg,

On Wed, 16 Sep 2009 15:36:57 -0700, Greg KH wrote:
> 2.6.31-stable review patch.  If anyone has any objections, please let us know.
> 
> ------------------
> From: Jean Delvare <khali@xxxxxxxxxxxx>
> 
> commit 6b5096e4d4496e185cd1ada5d1b8e1d941c805ed upstream.
> 
> One more form factor for Compaq Evo D510, which needs the same quirk
> as the other form factors. Apparently there's no hardware monitoring
> chip on that one, but SPD EEPROMs, so it's still worth unhiding the
> SMBus.

FWIW, this one doesn't strike me as being needed in -stable. While it
should be safe (otherwise it wouldn't have gone upstream in the first
place), it hardly fulfills -stable's requirement that "it must fix a
real bug that bothers people". There's no hardware monitoring chip on
the SMBus on this machine, and people can easily live without detailed
memory module information.

So it's up to you, but I won't cry if you drop this patch from -stable.

> 
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Tested-by: Nuzhna Pomoshch <nuzhna_pomoshch@xxxxxxxxx>
> Signed-off-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> 
> ---
>  drivers/pci/quirks.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -1201,6 +1201,7 @@ static void __init asus_hides_smbus_host
>  			switch(dev->subsystem_device) {
>  			case 0x00b8: /* Compaq Evo D510 CMT */
>  			case 0x00b9: /* Compaq Evo D510 SFF */
> +			case 0x00ba: /* Compaq Evo D510 USDT */
>  				/* Motherboard doesn't have Host bridge
>  				 * subvendor/subdevice IDs and on-board VGA
>  				 * controller is disabled if an AGP card is
> 
> 


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/