Re: [PATCH] Remove broken by design and by implementation devtmpfsmaintenance disaster

[Greg KH]

On Thu, Sep 17, 2009 at 02:05:48PM +0100, Alan Cox wrote:
> On Thu, 17 Sep 2009 05:57:59 -0700
> Greg KH <greg@xxxxxxxxx> wrote:
> 
> > On Thu, Sep 17, 2009 at 01:23:39AM -0700, Eric W. Biederman wrote:
> > > 
> > > devtmpfs has numerous problems.  The once I see from a quick review.
> > 
> > <snip>
> > 
> > I'm confused, why did you not at least cc: Kay and I on this message, if
> > I was a paranoid person, I would think that you were somehow trying to
> > skirt around us for some unknown reason :(
> > 
> > I think Kay has raised the proper points already.
> 
> I've seen nacks from Christoph and from Eric and it seems Al Viro has yet
> to review devtmpfs. I'd like to see Al's opinion personally.

That's fine, but as it's just using the standard tmpfs interfaces that
other in-kernel virtual filesystems use, it shouldn't need that much
review.  The code is quite small as well, and I thought Al was still on
an extended vacation.

This code has been reviewed and posted numerous times for over 6 months
now, which should be plenty of time for us to be waiting for a review,
don't you?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/