Re: rt2x00dev.c:405: error: too few arguments to function ârt2x00crypto_rx_insert_ivâ

From: John W. Linville
Date: Thu Sep 17 2009 - 16:00:46 EST


On Thu, Sep 17, 2009 at 07:11:33PM +0100, Andrew Price wrote:
> On Thu, Sep 17, 2009 at 01:23:59PM -0400, John W. Linville wrote:
> > On Thu, Sep 17, 2009 at 04:41:39PM +0100, Andrew Price wrote:
> > > Hi Ivo,
> > >
> > > Apologies if this has already been reported. Building today's mainline
> > > kernel (ab86e5) I'm seeing this error:
> > >
> > > drivers/net/wireless/rt2x00/rt2x00dev.c: In function ârt2x00lib_rxdoneâ:
> > > drivers/net/wireless/rt2x00/rt2x00dev.c:405: warning: passing argument 3 of ârt2x00crypto_rx_insert_ivâ makes integer from pointer without a cast
> > > drivers/net/wireless/rt2x00/rt2x00dev.c:405: error: too few arguments to function ârt2x00crypto_rx_insert_ivâ
> >
> > Strange...I don't see this warning. Are you sure you have a clean checkout?
>
> I double-checked:
>
> - git status returned no changes
> - git clean -fqdx
> - ccache -C
> - Retried the build
>
> and still got the same error. Is this something to do with the second
> definition of rt2x00crypto_rx_insert_iv still having an l2pad parameter...
>
> This (untested) patch fixes the build for me:

Oh, I see now -- thanks for the patch! FWIW, it would seem to only
show-up when you have CONFIG_RT2500PCI but none of the other rt2x00
family drivers in your .config...

John

P.S. Could you resubmit to linux-wireless@xxxxxxxxxxxxxxx, following
the normal patch submission guidelines as discussed here?

http://linux.yyz.us/patch-format.html

--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/