Re: [PATCH] fix BUILD_BUG_ON() and a couple of bogus uses of it

[Andrew Morton]

On Thu, 17 Sep 2009 17:15:04 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> There's a shortcoming in the current BUILD_BUG_ON() - it silently does
> nothing if passed a non-constant arg.
> 
> I suspect that in the 2.6.31 code, that BUILD_BUG_ON() just does
> nothing at all, and that Jan's patch is now exposing this.  It might be
> compiler-version dependent too.
> 
> 
> <tests it>
> 
> Yup, on base 2.6.31, this:
> 
> --- a/arch/sparc/kernel/vio.c~a
> +++ a/arch/sparc/kernel/vio.c
> @@ -23,6 +23,8 @@ static const struct vio_device_id *vio_m
>  	const char *type, *compat;
>  	int len;
>  
> +	vio_dring_avail(NULL, 33);
> +
>  	type = dev->type;
>  	compat = dev->compat;
>  	len = dev->compat_len;
> _
> 
> compiles without error with gcc-3.4.5.

And I can't immediately find a way to make any compile-time error occur here, with
or without Jan's patch.  hm.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/