Re: [PATCH] Remove broken by design and by implementation devtmpfs maintenance disaster

[Eric W. Biederman]

Greg KH <greg@xxxxxxxxx> writes:

> I'm really sorry, but I know of no existing bugs in this code.
> Seriously, I thought we addressed everything that was pointed out.

Then please sober up and open your eyes.  Bugs are not hard to find.
And I pointed out about 5 of them at the beginning of my message.

The simplest and most trivial of them is that the error handling
path is device_add was not updated to remove the devtmpfs node
if it was not created.

I find it maximally offensive that when I try and give constructive
criticism that I am either written off or told that my patches will
be summarily dropped.

The code I think is fixable.  You I have much less hope for.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/