Re: [PATCH tip/core/rcu] RCU whitespace fixes

[Ingo Molnar]

* Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:

> Fix a number of whitespace ^Ierrors in the include/linux/rcu* and the 
> kernel/rcu* files.
> 
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> ---
> 
>  include/linux/rculist_nulls.h |    2 +-
>  include/linux/rcupdate.h      |    6 +++---
>  include/linux/rcutree.h       |    2 +-
>  kernel/rcupdate.c             |    4 ++--
>  kernel/rcutorture.c           |    4 ++--
>  kernel/rcutree.c              |    2 +-
>  kernel/rcutree.h              |    2 +-
>  kernel/rcutree_plugin.h       |    4 ++--
>  kernel/rcutree_trace.c        |    2 +-
>  9 files changed, 14 insertions(+), 14 deletions(-)

thanks Paul - i also did a few more checkpatch trivial fixes to create a 
clean baseline.

Here's a full list of the remaining 'problems' in kernel/rcu*.[ch] files 
checked via checkpatch --file kernel/rcu*.[ch] , with annotations by me 
that suggest resolutions:

[ Andy: see one checkpatch bug mentioned below. Plus it would be 
  _really_ nice if line 80 warnings would only be emitted if the line 
  also contains 2 or more tabs - i.e. excessive nesting. Longer than 100 
  lines should be warned about unconditionally. ]

-----------------------
WARNING: externs should be avoided in .c files
#262: FILE: rcupdate.c:262:
+extern int rcu_cpu_notify(struct notifier_block *self,

-----------------------> Move rcu_cpu_notify() prototype to rcutree.h?

WARNING: line over 80 characters
#87: FILE: rcutorture.c:87:
+	do { printk(KERN_ALERT "%s" TORTURE_FLAG s "\n", torture_type); } while (0)

-----------------------> Ignore.

WARNING: line over 80 characters
#89: FILE: rcutorture.c:89:
+	do { if (verbose) printk(KERN_ALERT "%s" TORTURE_FLAG s "\n", torture_type); } while (0)

-----------------------> Ignore.

WARNING: line over 80 characters
#91: FILE: rcutorture.c:91:
+	do { if (verbose) printk(KERN_ALERT "%s" TORTURE_FLAG "!!! " s "\n", torture_type); } while (0)

-----------------------> Ignore.

WARNING: line over 80 characters
#247: FILE: rcutorture.c:247:
+			schedule_timeout_interruptible(round_jiffies_relative(HZ));

-----------------------> Ignore.

WARNING: externs should be avoided in .c files
#609: FILE: rcutorture.c:609:
+extern int rcu_expedited_torture_stats(char *page);

-----------------------> Move rcu_expedited_torture_stats() prototype to sched.h?

CHECK: memory barrier without comment
#653: FILE: rcutorture.c:653:
+		smp_wmb();

-----------------------> Add comment?

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#56: FILE: rcutree.c:56:
+EXPORT_SYMBOL_GPL(rcu_lock_map);

-----------------------> checkpatch.pl bug?

WARNING: externs should be avoided in .c files
#84: FILE: rcutree.c:84:
+extern long rcu_batches_completed_sched(void);

-----------------------> Move rcu_batches_completed_sched() to sched.h?

WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc
#1498: FILE: rcutree.c:1498:
+	cprv = NR_CPUS;

-----------------------> Ignore.

WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc
#1535: FILE: rcutree.c:1535:
+			if (rnp->grphi >= NR_CPUS)

-----------------------> Ignore.

WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc
#1536: FILE: rcutree.c:1536:
+				rnp->grphi = NR_CPUS - 1;

-----------------------> Ignore.

WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc
#48: FILE: rcutree.h:48:
+#elif NR_CPUS <= RCU_FANOUT_SQ

-----------------------> Ignore.

WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc
#54: FILE: rcutree.h:54:
+#elif NR_CPUS <= RCU_FANOUT_CUBE

-----------------------> Ignore.

CHECK: spinlock_t definition without comment
#82: FILE: rcutree.h:82:
+	spinlock_t lock;

-----------------------> Add comment?

WARNING: struct file_operations should normally be const
#96: FILE: rcutree_trace.c:96:
+static struct file_operations rcudata_fops = {

-----------------------> Add const?

WARNING: struct file_operations should normally be const
#148: FILE: rcutree_trace.c:148:
+static struct file_operations rcudata_csv_fops = {

-----------------------> Add const?

ERROR: code indent should use tabs where possible
#162: FILE: rcutree_trace.c:162:
+^I              "nfqs=%lu/nfqsng=%lu(%lu) fqlh=%lu\n",$

-----------------------> s/        /^T/

WARNING: struct file_operations should normally be const
#199: FILE: rcutree_trace.c:199:
+static struct file_operations rcuhier_fops = {

-----------------------> Add const?

WARNING: struct file_operations should normally be const
#225: FILE: rcutree_trace.c:225:
+static struct file_operations rcugp_fops = {

-----------------------> Add const?

WARNING: struct file_operations should normally be const
#279: FILE: rcutree_trace.c:279:
+static struct file_operations rcu_pending_fops = {

-----------------------> Add const?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/