sched: Am I missing something?

From: Peter Williams
Date: Mon Sep 21 2009 - 09:22:52 EST


Or is the line:

p->prio = effective_prio(p);

in wake_up_new_task() an expensive no op.

As far as I can tell from reading the code, it will always be the case that EITHER rt_prio(p->prio) is true OR p->prio == p->normal_prio when this call is made and, in either case, the value of p->prio will be unchanged. In addition, when this call is made p->normal_prio is already equal to to normal_prio(p), so the side effects of the function (setting p->normal_prio) are also unnecessary.

Am I correct or have I missed something?

Peter
--
Peter Williams pwil3058@xxxxxxxxxxxxxx

"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/