[PATCH] drm: Fix build failure in radeon and i915 drivers

From: Ingo Molnar
Date: Mon Sep 21 2009 - 12:50:49 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> there's a new build failure:
>
> drivers/built-in.o: In function `drm_irq_uninstall':
> (.text+0xb719e): undefined reference to `vga_client_register'
> drivers/built-in.o: In function `drm_irq_install':
> (.text+0xb7309): undefined reference to `vga_client_register'
> drivers/built-in.o: In function `radeon_device_fini':
> (.text+0xe400f): undefined reference to `vga_client_register'
> drivers/built-in.o: In function `radeon_device_init':
> (.text+0xe455b): undefined reference to `vga_client_register'
>
> with the attached config, introduced with upstream merge 44040f1.
>
> At first sight it appears to be due to CONFIG_DRM_RADEON relying on
> VGA_ARB facilities but this is not expressed in the Kconfig rules. The
> patch below solves this - but this is just a quick patch, i have not
> investigated any deeper.
>
> Review of the code suggests that i915 has a similar dependency problem
> - i fixed that too.

i've looked some more and drm_irq.o depends on vga-arb too so the patch
below is the more complete fix IMHO.

Ingo

------------------>