Re: [GIT PULL] a few writeback fixes

From: Jens Axboe
Date: Mon Sep 21 2009 - 15:02:29 EST


On Mon, Sep 21 2009, Ingo Molnar wrote:
>
> * Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
>
> > Hi Linus,
> >
> > This fixes a problem with NFS killing its bdi without being
> > initialized, and also contains a fix for a busy loop (where we forgot
> > to set the task state before sleeping). Since these are a bit critical
> > for -rc1, I'm pushing them out before leaving for Portland.
> >
> > Jan, since we're not really sure on the inode wait yet, I dropped that
> > patch. It's definitely something to look into, as are the congestion
> > bits.
> >
> > I plan on adding some writeback tracing code while on the plane for
> > further analysis when I get back.
> >
> > git://git.kernel.dk/linux-2.6-block.git writeback
> >
> > Jens Axboe (4):
> > nfs: nfs_kill_super() should call bdi_unregister() after killing super
> > writeback: don't use schedule_timeout() without setting runstate
> > writeback: make balance_dirty_pages() gradually back more off
> > nfs: initialize the backing_dev_info when creating the server
> >
> > fs/nfs/client.c | 10 ++++++----
> > fs/nfs/super.c | 2 +-
> > mm/page-writeback.c | 11 ++++++++++-
> > 3 files changed, 17 insertions(+), 6 deletions(-)
>
> just an update about the BDI slab corruption bugs i reported in this
> thread on lkml:
>
> [origin tree SLAB corruption] BUG kmalloc-64: Poison overwritten,
> INFO: Allocated in bdi_alloc_work+0x2b/0x100 age=175 cpu=1 pid=3514
>
> They have gone away entirely with your earlier BDI fixes/updates, on all
> -tip testsystems that triggered it. So that bug can be closed for good.

That's good, I was expecting Nicks fixes to resolve those. Thanks for
confirming!

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/