Re: [origin tree build failure] [PATCH] Re: [git pull] drm tree.

From: Dave Airlie
Date: Mon Sep 21 2009 - 23:56:22 EST



>
> there's a new build failure:
>
> drivers/built-in.o: In function `drm_irq_uninstall':
> (.text+0xb719e): undefined reference to `vga_client_register'
> drivers/built-in.o: In function `drm_irq_install':
> (.text+0xb7309): undefined reference to `vga_client_register'
> drivers/built-in.o: In function `radeon_device_fini':
> (.text+0xe400f): undefined reference to `vga_client_register'
> drivers/built-in.o: In function `radeon_device_init':
> (.text+0xe455b): undefined reference to `vga_client_register'
>
> with the attached config, introduced with upstream merge 44040f1.
>
> At first sight it appears to be due to CONFIG_DRM_RADEON relying on
> VGA_ARB facilities but this is not expressed in the Kconfig rules. The
> patch below solves this - but this is just a quick patch, i have not
> investigated any deeper.
>
> Review of the code suggests that i915 has a similar dependency problem -
> i fixed that too.

The way it should work is VGA ARB should be enabled on any platforms we
have PCI unless EMBEDDED turns it off, since arbitration of VGA isn't
reliant on a drm device, I'm not sure what Kconfig magic this would
require, and where it would need to be. This patch should at least allow
builds to work until I figure out any Kconfig magic.