Re: [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip

[Tomaz Mertelj]

At 14:44 21. 9. 2009 -0700, Andrew Morton wrote:
> On Wed, 9 Sep 2009 09:34:35 +0200
> Jean Delvare <khali@xxxxxxxxxxxx> wrote:
>
> > > #define set_temp_para(name, reg)\
> > > static ssize_t set_##name(\
> > >             struct device *dev,\
> > >             struct device_attribute *attr,\
> > >             const char *buf,\
> > >             size_t count)\
> > > {\
> > >     return set_helper(dev, attr, buf, count, &dev->name);\
> > > }
> > >
> > > And then do all the real work in a common function?  Rather than
> > > expanding tens of copies of the same thing?
> >
> > Yes please. We got rid of macro-generated callbacks in most hwmon
> > drivers a couple years ago already.
>
> I never received an update to this patch so I'm retaining it in my tree
> for now.


OK. I have an update almost ready. I only need some time to test it.

Should I post a patch on top of the original patch or a full patch to the 
latest kernel tree?

Tomaz Mertelj


***********************************************************************************
Tomaz Mertelj
E-mail: tomaz.mertelj@xxxxxxxxxxxxxx    Home page: 
http://optlab.ijs.si/tmertelj


Staniceva 14
1000 Ljubljana
Slovenia
***********************************************************************************



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/