Re: regression in page writeback

From: Andrew Morton
Date: Tue Sep 22 2009 - 22:56:52 EST


On Wed, 23 Sep 2009 10:49:58 +0800 Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:

> > After the sleep we repoll all queues.
>
> I mean, it is not always necessary. Only when _all_ superblocks cannot
> writeback their inodes (eg. all in congestion), we should wait.

Well. The code will still submit MAX_WRITEBACK_PAGES pages to _some_
queue in that situation.

But yup, maybe that's a bug! Sounds easy to fix. It doesn't justify
rewriting the whole world and then saying "look, the new code is faster
than the old code which had a bug which I knew about but didn't fix".

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/