Re: [PATCH] vfs: new FROM_ACCESS flag

From: Jamie Lokier
Date: Wed Sep 23 2009 - 04:48:35 EST


Christoph Hellwig wrote:
> On Tue, Sep 22, 2009 at 01:28:46PM -0400, Eric Paris wrote:
> > > only using MAY_ACCESS for calles from access() insteaf of introducing
> > > a FROM_ACCESS flag and causing lots of naming confusion.
> >
> > What would you think of a new, MUST_REVALIDATE_PERMS which will do what
> > MAY_ACCESS does today. MAY_ACCESS would be just for access(2) and would
> > be the flag that I use for SELinux?
>
> Yeah, something like this. I don't like the MUST_REVALIDATE_PERMS name
> too much, but unless someone comes up with a better one I can live with
> it.

MAY_ACCESS is used in only these places:

- access/faccessat
- chdir/fchdir
- chroot

And it is checked in only two easy to change places: nfs/dir.c and
fuse/dir.c.

Therefore how about MAY_CHDIR.

-- Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/