[tip:tracing/urgent] modules, tracing: Remove stale struct marker signature from module_layout()

From: tip-bot for Ingo Molnar
Date: Wed Sep 23 2009 - 05:05:43 EST


Commit-ID: 115e8a288252ef748f34f8b7c1115c563d702eda
Gitweb: http://git.kernel.org/tip/115e8a288252ef748f34f8b7c1115c563d702eda
Author: Ingo Molnar <mingo@xxxxxxx>
AuthorDate: Mon, 21 Sep 2009 18:22:11 +0200
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Wed, 23 Sep 2009 10:34:21 +0200

modules, tracing: Remove stale struct marker signature from module_layout()

Linus reported this new build warning:

kernel/module.c:2951: warning: ?struct marker? declared inside parameter list
kernel/module.c:2951: warning: its scope is only this definition or declaration, which is probably not what you want

Caused by:

fc53776: tracing: Remove markers

module_layout() is an artificial symbol with 'significant' symbols
listed in its argument list so that it gets a proper argument types
signature that modversions can pick up to decide whether a
module is version-compatible or not. If these dont match then we
wont even look at a module.

Remove the stale marker symbol.

Reported-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
LKML-Reference: <alpine.LFD.2.01.0909210908020.4950@xxxxxxxxxxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>


---
kernel/module.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index b6ee424..392eb3d 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2947,7 +2947,6 @@ void module_layout(struct module *mod,
struct modversion_info *ver,
struct kernel_param *kp,
struct kernel_symbol *ks,
- struct marker *marker,
struct tracepoint *tp)
{
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/