Re: [origin tree boot hang] [PATCH] Revert "early_printk:Allowmorethanone early console"

[Linus Torvalds]

On Wed, 23 Sep 2009, Jason Wessel wrote:
> 
> Perhaps you will consider adding this patch to your tree?   It fixes the
> specific case you mentioned.  It will still allow the board to boot and
> instead of crashing, print a warning on the second instance.

Ugh. This looks totally bogus.

Why don't you just add CON_REGISTERED to the console flags, and do

	/* Already registered? */
	if (early_console->flags & CON_REGISTERED)
		return;
	early_console->flags |= CON_REGISTERED;

there instead? That whole "loop over existing consoles to check their 
names" looks silly and broken, and you're already playing with the flags 
in there (CON_BOOT).

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/