Re: [PATCH] Revert "kmod: fix race in usermodehelper code"

From: Linus Torvalds
Date: Wed Sep 23 2009 - 19:43:54 EST




On Thu, 24 Sep 2009, Sebastian Andrzej Siewior wrote:
>
> The pach is wrong IMHO. UMH_WAIT_EXEC is called with VFORK what ensures
> that the child finishes prior returing back to the parent. No race. The patch
> makes it even worse because it does the thing it claims not do:
> - It calls ->complete() on UMH_WAIT_EXEC
> - the complete() callback may de-allocated subinfo

Yeah, I think you're right. That commit is bogus. Thanks for noticing.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/