Re: [patch 04/33] fs: brlock vfsmount_lock

From: Nick Piggin
Date: Sun Sep 27 2009 - 15:56:25 EST


On Tue, Sep 22, 2009 at 04:17:51PM +0100, Al Viro wrote:
> On Fri, Sep 04, 2009 at 04:51:45PM +1000, npiggin@xxxxxxx wrote:
> > Use a brlock for the vfsmount lock.
>
> I like it, but I'd like to see how costly it becomes on heavily SMP boxen.
> Creation/removal of bindings as load...

I could test that... Is there some realistic scenario I can try
to implement that exercises this? (failing that, I'll happily
do a microbenchmark).

I was thinking it *might* be possible to do RCU... but especially
coming up with a scheme that avoids synchronize_rcu() in the
umount path is not trivial, so perhaps the simple read/write
annotations with brlock behind the scenes is a more reasonable step.

I do also actually owe you some documentation with this one too,
which I will get around to adding.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/