Re: [PATCH] tty: fix vt_compat_ioctl

[Florian Mickler]

Hi!

On Mon, 28 Sep 2009 21:21:14 +0200
Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:

> Greg KH <gregkh@xxxxxxx> writes:
> 
> > On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote:
> >> Call compat_unimap_ioctl, not do_unimap_ioctl.
> >
> > That's a nice description of what the patch does, but why do we need to
> > do that?
> 
> It's a compat ioctl handler, so lets call the compat ioctl handler.
> 
> Andreas.
> 

Any other reasons? Why not rename the call then? That would be a
functional no-op with the same effect... 


Sincerely,
Florian

p.s. maybe it is obvious if one looks at the code (i didnt), but it
should be described nonetheless in the commit-log!

-- 
A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?  
>> A: Top-posting.  
>>> Q: What is the most annoying thing in e-mail?

Attachment: signature.asc
Description: PGP signature