Re: [PATCH 3/5] mce-inject: make injected mce valid only during fakedhandler call

[Hidetoshi Seto]

Andi Kleen wrote:
>> This has an undesired side-effect: it is possible for it to be
>> consumed by real machine_check_poll. This may confuse a real system
>> error and may confuse the mce test suite.
> 
> You can just disable the poll handler in the test suite. That's
> what we did.

I'd like to fix this simply, rather than providing documentation like
"you should turn off polling before you use the mce-inject."

>> The injectm.valid becomes "2" only during faked MCE handler call
>> and protected by IRQ disabling. This make it impossible for real
>> machine_check_poll to consume it.
> 
> Using magic numbers for this seems very hackish.

Right.  I'll take other approach in next time.


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/