Re: [PATCH,TRIVIAL] Fix csum_ipv6_magic asm memory clobber

From: H. Peter Anvin
Date: Wed Sep 30 2009 - 19:46:42 EST


On 09/30/2009 04:22 PM, David Miller wrote:
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 30 Sep 2009 16:19:39 -0700
>
>> From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
>>
>> Just like ip_fast_csum, the assembly snippet in csum_ipv6_magic needs a
>> memory clobber, as it is only passed the address of the buffer, not a
>> memory reference to the buffer itself.
>>
>> This caused failures in Hurd's pfinetv4 when we tried to compile it with
>> gcc-4.3 (bogus checksums).
>>
>> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
>> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> I'm happy to see this go in via the x86 tree, and thus:
>
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

I'll put it in x86/urgent tonight or early tomorrow morning (just about
to leave for the airport.)

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/