Re: [2.6.32-rc3 kmemleak] WARNING: at kernel/lockdep.c:3161check_flags+0xbe/0x180()

From: Catalin Marinas
Date: Mon Oct 05 2009 - 04:57:22 EST


On Mon, 2009-10-05 at 12:15 +0900, Tetsuo Handa wrote:
> [PATCH 2.6.32-rc3] kmemleak: Use GFP_ATOMIC for early_alloc().
>
> We can't use GFP_KERNEL inside rcu_read_lock().
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> ---
> mm/kmemleak.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.32-rc3.orig/mm/kmemleak.c
> +++ linux-2.6.32-rc3/mm/kmemleak.c
> @@ -833,7 +833,7 @@ static void early_alloc(struct early_log
> */
> rcu_read_lock();
> object = create_object((unsigned long)log->ptr, log->size,
> - log->min_count, GFP_KERNEL);
> + log->min_count, GFP_ATOMIC);
> spin_lock_irqsave(&object->lock, flags);
> for (i = 0; i < log->trace_len; i++)
> object->trace[i] = log->trace[i];

Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>

Thanks.

--
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/