Re: [patch] kbuild: Improve version string logic

From: David Rientjes
Date: Tue Oct 06 2009 - 22:45:43 EST


On Tue, 6 Oct 2009, Ingo Molnar wrote:

> Subject: kbuild: Improve version string logic
> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Date: Tue, 6 Oct 2009 09:31:03 -0700 (PDT)
>
> It changes how CONFIG_LOCALVERSION_AUTO works, in the following trivial
> way:
>
> - if it is set, things work the way they always have, and you get a
> extended kernel release like:
>
> 2.6.32-rc3+00052-g0eca52a-dirty
>
> ( with the difference that the extra version string is separated via
> '+' not via '-'. This improves visibility when we have additional
> changes over a vanilla tag. )
>

s/changes/commits/, we'd have to look at the -dirty suffix for uncommited
changes.

The '+' doesn't necessarily always mean there are additional changes since
scripts/setlocalversion will return -00000-EXTRAVERSION when we're at a
release. So when CONFIG_LOCALVERSION_AUTO is enabled, this patch would,
for example, create the version 2.6.32-rc3+00000-rc3.

Perhaps we should suppress setlocalversion's output if git describe
doesn't have a 7-character trailing hash prefixed with 'g'?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/