Re: [PATCH 1/4] signals: SEND_SIG_NOINFO should be considered asSI_FROMUSER()

From: Roland McGrath
Date: Wed Oct 07 2009 - 21:59:06 EST


> I think this doesn't matter because we need more cleanups.

Ok, good enough for me.

> The problem is, both SI_FROMUSER() and SI_FROMKERNEL() must die imho.
> In fact I think they should never exist.

I've always found all the si_code hackery rather confusing. (Don't forget
the crucial magic (short) cast repeated three places in exit.c without a
comment between them!)

> Other cleanups which imho makes sense:
>
> - rename SEND_SIG_XXX
>
> - redefine them to make sure SEND_SIG_NOINFO != NULL

Sounds good to me.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/