Re: [PATCH 18/45] writeback: introduce wait queue forbalance_dirty_pages()

[Peter Zijlstra]

On Thu, 2009-10-08 at 09:58 +0800, Wu Fengguang wrote:
> 
> > How this runqueue->nr_iowait is handled now ?
> 
> Good question. io_schedule() has an old comment for throttling IO wait:
> 
>          * But don't do that if it is a deliberate, throttling IO wait (this task
>          * has set its backing_dev_info: the queue against which it should throttle)
>          */
>         void __sched io_schedule(void)
> 
> So it looks both Jens' and this patch behaves right in ignoring the
> iowait accounting for balance_dirty_pages() :)

Well it is a change in behaviour, and I think IOWAIT makes sense when
we're blocked due to io throttle..

Hmm?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/