Re: [PATCH] writeback: account IO throttling wait as iowait

From: Wu Fengguang
Date: Fri Oct 09 2009 - 07:00:44 EST


On Fri, Oct 09, 2009 at 06:41:05PM +0800, Jens Axboe wrote:
> > ---
> > writeback: account IO throttling wait as iowait
> >
> > It makes sense to do IOWAIT when someone is blocked
> > due to IO throttle, as suggested by Kame and Peter.
> >
> > There is an old comment for not doing IOWAIT on throttle,
> > however it has been mismatching the code for a long time.
> >
> > If we stop accounting IOWAIT for 2.6.32, it could be an
> > undesirable behavior change. So restore the io_schedule.
>
> Thanks, queued up.

Thank you. Would you also pick up this one if it's OK to you?

Thanks,
Fengguang

---
writeback: kill space in debugfs item name

The space is not script friendly, kill it.

CC: Jens Axboe <jens.axboe@xxxxxxxxxx>
Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
---
mm/backing-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux.orig/mm/backing-dev.c 2009-10-09 10:05:27.000000000 +0800
+++ linux/mm/backing-dev.c 2009-10-09 18:55:27.000000000 +0800
@@ -92,7 +92,7 @@ static int bdi_debug_stats_show(struct s
"BdiDirtyThresh: %8lu kB\n"
"DirtyThresh: %8lu kB\n"
"BackgroundThresh: %8lu kB\n"
- "WriteBack threads:%8lu\n"
+ "WritebackThreads: %8lu\n"
"b_dirty: %8lu\n"
"b_io: %8lu\n"
"b_more_io: %8lu\n"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/