Re: [PATCH 2/2] kmemleak: Check for NULL pointer returned by create_object()

[Pekka Enberg]

On Fri, Oct 9, 2009 at 12:30 PM, Catalin Marinas
<catalin.marinas@xxxxxxx> wrote:
> This patch adds NULL pointer checking in the early_alloc() function.
>
> Reported-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>

Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

> ---
>  mm/kmemleak.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index a617518..8bf765c 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -834,11 +834,14 @@ static void early_alloc(struct early_log *log)
>        rcu_read_lock();
>        object = create_object((unsigned long)log->ptr, log->size,
>                               log->min_count, GFP_ATOMIC);
> +       if (!object)
> +               goto out;
>        spin_lock_irqsave(&object->lock, flags);
>        for (i = 0; i < log->trace_len; i++)
>                object->trace[i] = log->trace[i];
>        object->trace_len = log->trace_len;
>        spin_unlock_irqrestore(&object->lock, flags);
> +out:
>        rcu_read_unlock();
>  }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/