Re: [PATCH] tracing - enable records during the module load

From: Steven Rostedt
Date: Sat Oct 10 2009 - 11:29:38 EST


On Sat, 2009-10-10 at 16:00 +0200, jolsa@xxxxxxxxxx wrote:
> I was debuging some module using "function" and "function_graph" tracers
> and noticed, that if you load module after you enabled tracing, the module's
> hooks will convert only to NOP instructions.

Yeah, I knew when I wrote this that new modules loaded during tracing
would just be initialized as nops, and not become part of that trace.
They will become part of later traces if the function tracing is stopped
and started again.

Actually, I took that as a safety feature, since most bad things can
happen when modules load and unload. But, I think your patch is still
safe. I'll apply it, play with it a bit, then queue it up for 2.6.33.

Thanks,

-- Steve

>
> The attached patch enables modules' hooks if there's function
> trace allready on, thus allowing to trace module functions.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/