Re: [PATCH 15/21] kernel/power/: use pr_<level> and add pr_fmt(fmt)

From: Pavel Machek
Date: Sun Oct 11 2009 - 05:00:22 EST



> > Here's the same patch redone against -next.
> >
> > Added #define pr_fmt(fmt) "PM: " fmt
> > Converted printk(KERN_<level> to pr_<level>(
> > Converted printks without KERN_ to pr_info or pr_cont
> > Removed hard coded "PM: " prefix from message strings
> > Added pr_fmt() to __initdata strings
> > Integrated multiple line strings
> > All logging messages are now output prefixed with "PM: "
>
> Does this patch depend on any other patch that haven't been merged yet?
>
> I still don't like pr_info(), pr_error() and pr_crit().

Well, rest of kernel uses them, they are shorter, and will save few
bytes too... so why not?
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/