Re: [PATCH RFC] [PATCH] drivers/scsi/ch.c: Remove BKL in ch_open

[Arjan van de Ven]

On Sun, 11 Oct 2009 17:14:03 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> > > But module load/unload does
> > 
> > it does?
> > 
> > looking at the code.... so far failing to find where.
> 
> Interesting - it used to and there is code that still relies on that.

I can't find that to be the case anymore though

> 
> The more general problem of
> 
> 	register_chrdev
> 					open
> 	do something
> 	error
> 	unload
> 					whoops
> 
> definitely needs looking at however.

absolutely

we used to have the same issue with networking devices,
and there it ended up with a split "allocate" and "register"




-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/