Re: [PATCH] sound_core.c: Remove BKL from soundcore_open

From: Takashi Iwai
Date: Mon Oct 12 2009 - 02:07:20 EST


At Sun, 11 Oct 2009 14:41:15 +0200 (CEST),
John Kacur wrote:
>
> @@ -631,17 +629,17 @@ static int soundcore_open(struct inode *inode, struct file *file)
> file->f_op = new_fops;
> spin_unlock(&sound_loader_lock);
> if(file->f_op->open)
> + lock_kernel();
> err = file->f_op->open(inode,file);
> + unlock_kernel();

You certainly want braces around here, no?


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/