[origin tree build failure] [PATCH] Revert "USB: musb: makeHAVE_CLK support optional"
From: Ingo Molnar
Date: Mon Oct 12 2009 - 03:44:16 EST
* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> As usual, please test this for regressions, both new and old.
> USB: musb: make HAVE_CLK support optional
This USB/Blackfin commit broke the x86 build with these config options:
CONFIG_USB_MUSB_HDRC=y
CONFIG_USB_MUSB_HOST=y
# CONFIG_USB_MUSB_PERIPHERAL is not set
# CONFIG_USB_MUSB_OTG is not set
# CONFIG_USB_GADGET_MUSB_HDRC is not set
CONFIG_USB_MUSB_HDRC_HCD=y
CONFIG_MUSB_PIO_ONLY=y
CONFIG_USB_MUSB_DEBUG=y
Because a side-effect of the patch was that it enabled the driver on x86
too which doesnt have HAVE_CLK. So this formerly embedded-only driver
got exposed on the more widely tested x86 platform.
The changelog does not mention this side-effect so i suspect it was
unintended - so below is the revert of the commit.
Ingo
-------------------->