Re: [PATCH tracing/kprobes v3 4/7] tracing/kprobes: Avoid field nameconfliction

From: Masami Hiramatsu
Date: Mon Oct 12 2009 - 15:11:49 EST


Frederic Weisbecker wrote:
The conflict issue might not be obvious for a user desperately trying to set
a kprobe. Even for other failcases, it might not be obvious (blacklisted
symbols, syntax errors...)

May be should you improve the error granularity and print a KERN_DEBUG
message?

Agreed, and kprobes error handling should be improved too (in the most cases,
it just returns -EINVAL).

Thank you.

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/