Re: [REGRESSION] "bind" a device to a driver doesn't not workanymore

From: Greg KH
Date: Mon Oct 12 2009 - 16:26:51 EST


On Mon, Oct 12, 2009 at 12:20:46PM -0700, Dmitry Torokhov wrote:
> On Mon, Oct 12, 2009 at 11:54:17AM -0700, Greg KH wrote:
> > On Mon, Oct 12, 2009 at 11:33:13AM -0700, Dmitry Torokhov wrote:
> > > On Mon, Oct 12, 2009 at 10:35:51AM -0700, Greg KH wrote:
> > > > On Mon, Oct 12, 2009 at 08:48:46AM -0700, Dmitry Torokhov wrote:
> > > > > > So at least, unbind should fail as well as bind.
> > > > > >
> > > > >
> > > > > That would be Greg's domain s it is driver core decision whether to
> > > > > allow unbinding platform devices registered with
> > > > > platform_driver_probe().
> > > >
> > > > No, I do not see why that should not be allowed.
> > > >
> > >
> > > Because once you did unbind the device you are stuck (unless the driver
> > > is compiled as a module, but then you could just unload the module
> > > instead of unbinding). Disallowing unbind would allow discarding not
> > > only __devinit but __devexit sections when driver is built in which
> > > would make ebedded people happy[^Hier].
> >
> > Yeah, good point.
> >
> > Does anyone do bind/unbind with platform devices today?
> >
>
> Greg, meet Eric ;)

Heh, yes, I mean for a "useful" thing :)

Eric is trying to do this to resolve a bug in the driver, not a thing
that is "normally" done for platform devices.

> Although I'd really want to fix the resume issue so it works out of the
> box without needing to bind/unbind or reload i8042.

I agree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/