Re: USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH]

From: Benjamin Herrenschmidt
Date: Mon Oct 12 2009 - 17:22:38 EST


On Mon, 2009-10-12 at 10:58 -0400, Alan Stern wrote:
> Except that this is wrong. We can retry if temp_result ==
> USB_STOR_TRANSPORT_FAILURE, but we should not retry if temp_result ==
> USB_STOR_TRANSPORT_ERROR.
>
> Alan Stern
>
> P.S.: In case you don't already know... TRANSPORT_FAILURE means we
> were able to communicate with the device, and it told us that it
> couldn't carry out the command. TRANSPORT_ERROR means we weren't able
> to communicate with the device.

Ah good, I was wondering about precisely that (discriminating the errors
more intelligently). No point retrying if the device was yanked or went
totally dead.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/