Re: [PATCH -mm] connector: Passing required parameter for functioncn_add_callback.

From: David Miller
Date: Tue Oct 13 2009 - 02:43:16 EST


From: Rakib Mullick <rakib.mullick@xxxxxxxxx>
Date: Tue, 13 Oct 2009 11:27:49 +0600

> On 10/12/09, David Miller <davem@xxxxxxxxxxxxx> wrote:
>> From: Rakib Mullick <rakib.mullick@xxxxxxxxx>
>> Date: Mon, 12 Oct 2009 08:44:33 +0600
>>
>>
>> > */
>> > -static void cn_proc_mcast_ctl(struct cn_msg *msg)
>> > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
>> > netlink_skb_parms *nsp)
>>
>>
>> Your patches are unusable because your email client corrupts the
>> patch, here you can see it is splitting up long lines.
>>
>> Please fix this up and resubmit.
> Oops..... sorry for that. This is the second time I'm facing this
> problem. I'll try to fix it.
> I'm resubmitting the patch. Here I've recreate the patch to split the
> line into two.
> And it just reaches its 80 line mark. Hopefully it will be okay.

Upstream and my net-next-2.6 tree both have this function with
the proper parameters, maybe Andrew's -mm tree had some conflicts
and they weren't dealt with correctly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/