Re: [PATCH] [PERF] do not manually count string lengths

[Ingo Molnar]

* Vincent Legoll <vincent.legoll@xxxxxxxxx> wrote:

> On Tue, Oct 13, 2009 at 12:01 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> > We should add 'F:' file patterns to that entry i guess ...
> >
> > Something like:
> >
> > F:      kernel/perf_event.c
> > F:      include/linux/perf_event.h
> > F:      arch/*/*/kernel/perf_event.c
> > F:      arch/*/include/asm/perf_event.h
> > F:      tools/perf/
> >
> > Would do the trick. Mind sending a patch for that too?
> 
> Yep, I'll do, but a quick find in the tree may reveal other
> suspects that could be in the same league:
> 
> $ find . -name .git -prune -false -o -name drivers -prune \
> -false -o -name '*perf*' | grep -v perfmon | grep -v gperf
> 
> arch/*/kernel/perf_event.c
> 
> arch/frv/lib/perf_event.c
> arch/x86/kernel/cpu/perf_event.c
> 
> or maybe not:
> 
> arch/powerpc/kernel/perf_callchain.c
> arch/parisc/kernel/perf_asm.S
> arch/parisc/kernel/perf_images.h
> arch/parisc/kernel/perf.c
> arch/parisc/include/asm/perf.h
> 
> Was your list really comprehensive ?

ah, yes - perf_callchain.c too indeed. The pattern does not have to be 
100% full coverage.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/