Re: [PATCH] pata_sc1200: Fix crash on boot

[Alexandros C. Couloumbis]

On Tue, 13 Oct 2009 18:56:37 -0700, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 06 Oct 2009 16:07:51 +0100 Alan Cox <alan@xxxxxxxxxxxxxxx>
wrote:
> 
>> The SC1200 needs a NULL terminator or it may cause a crash on boot.
>> 
>> Bug #14227
>> 
>> Also correct a bogus comment as the driver had serializing added so can
>> run
>> dual port.
>> 
>> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
>> ---
>> 
>>  drivers/ata/pata_sc1200.c |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>> 
>> 
>> diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c
>> index f49814d..3bbed83 100644
>> --- a/drivers/ata/pata_sc1200.c
>> +++ b/drivers/ata/pata_sc1200.c
>> @@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev,
>> const struct pci_device_id *id)
>>  		.udma_mask = ATA_UDMA2,
>>  		.port_ops = &sc1200_port_ops
>>  	};
>> -	/* Can't enable port 2 yet, see top comments */
>> -	const struct ata_port_info *ppi[] = { &info, };
>> +	const struct ata_port_info *ppi[] = { &info, NULL };
>>  
>>  	return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL);
>>  }
> 
> This patch applies to 2.6.31 and 2.6.30 (at least).  How far back
> should it be ported?
> 
> There was no Cc:stable in the changelog.
> 
> There was no Cc:stable in the mail headers.  Nor cc:linux-ide.
> 
> Adding a Reported-by: is nice.
> 
> Please use the form
> 
> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14227
> 
> when mentioning bugzilla reports within changelogs.  To provide a nice
> greppable pattern for those people who might close off old reports for
us.

According to the git-tree this feature was introduced on linux kernel
2.6.30:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.30.y.git;a=commitdiff;h=c0f2ee34a5a0b79fd98d965ad8ae765d4639bfa5

2.6.29 and older kernels do not have this change/feature
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/