Re: [PATCH 13/16] percpu: remove per_cpu__ prefix.

From: H. Peter Anvin
Date: Wed Oct 14 2009 - 13:41:41 EST


On 10/14/2009 09:42 AM, Luck, Tony wrote:
>>> -#define __ia64_per_cpu_var(var) per_cpu__##var
>>> +#define __ia64_per_cpu_var(var) var
>>
>> IA64 could completely drop the macro? Tony?
>
> A #define that just returns its original argument untouched
> does seem to be a no-op. So I suppose we could just fix
> the dozen or so places where it is used to just use the
> variable directly.
>

Okay... I also don't seem to understand the more fundamental issue here,
which is:

Why are we dropping the prefix?

It may be "insufficient", but at least it stands out like a sore thumb
and makes mistakes harder. It would be a different thing if we could
actually use the TLS ABI, but we really can't.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/