Re: [PATCH 1/9] swap_info: private to swapfile.c

[Hugh Dickins]

On Fri, 16 Oct 2009, Nigel Cunningham wrote:
> Hugh Dickins wrote:
> > The swap_info_struct is mostly private to mm/swapfile.c, with only
> > one other in-tree user: get_swap_bio().  Adjust its interface to
> > map_swap_page(), so that we can then remove get_swap_info_struct().
> > 
> > But there is a popular user out-of-tree, TuxOnIce: so leave the
> > declaration of swap_info_struct in linux/swap.h.
> 
> Sorry for the delay in replying.

Delay?  Not at all!  Just leave the delays to me ;)

> 
> I don't mind if you don't leave swap_info_struct in
> include/linux/swap.h.

Okay, thanks for the info, that's good.  I won't take it out of swap.h
at this point, I'm finished in that area for now; but it's useful to
know that later on we can do so.

> I'm currently reworking my swap support anyway,

There should be better ways to interface to it than get_swap_info_struct().

> adding support for honouring the priority field. I've also recently
> learned that under some circumstances, allocating all available swap can
> take quite a while (I have a user who is hibernating with 32GB of RAM!),
> so I've been thinking about what I can do to optimise that.

Have fun!

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/