Re: [PATCH] jiffies.c: fix symbol was not declared noise

From: Yong Zhang
Date: Sun Oct 18 2009 - 02:18:39 EST


On Sat, Oct 17, 2009 at 6:26 AM, H Hartley Sweeten
<hartleys@xxxxxxxxxxxxxxxxxxx> wrote:
> In kernel/time/jiffies.c, clocksource_jiffies should be static.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Yong Zhang <yong.zhang0@xxxxxxxxx>

Cc'ed some experts.

>
> ---
>
> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
> index 5404a84..36d2d83 100644
> --- a/kernel/time/jiffies.c
> +++ b/kernel/time/jiffies.c
> @@ -55,7 +55,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
> Â Â Â Âreturn (cycle_t) jiffies;
> Â}
>
> -struct clocksource clocksource_jiffies = {
> +static struct clocksource clocksource_jiffies = {
>    Â.name      = "jiffies",
>    Â.rating     = 1, /* lowest valid rating*/
>    Â.read      = jiffies_read,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/