Re: [PATCH] lib/checksum.c: Fix another endianess bug

From: Matt Fleming
Date: Sat Oct 24 2009 - 08:00:06 EST


On Mon, Sep 28, 2009 at 04:39:38PM -0400, Mike Frysinger wrote:
> On Mon, Sep 28, 2009 at 04:07, Matt Fleming wrote:
> > On Fri, Sep 25, 2009 at 01:00:25PM -0400, Mike Frysinger wrote:
> >> On Fri, Sep 25, 2009 at 10:20, Matt Fleming wrote:
> >> > From: Matt Fleming <matthew.fleming@xxxxxxxxxx>
> >> >
> >> > This fix allows the generic checksum code to work on my little endian
> >> > system. The previous fix was not enough, as "buff" is a big-endian
> >> > value. Without this patch I see malformed TCP packets.
> >>
> >> can you try this one ?
> >> http://lkml.org/lkml/2009/6/23/597
> >
> > Yep, that one works fine also. Thanks, Mike. Who's going to pick this
> > up? I'm guessing this commit is also applicable for stable? Though, I
> > don't know if there are any little-endian users of this code in stable.
>
> i'm converting Blackfin to it now that the LE issues should be fixed,
> but i'm going to hold off on pushing the change until it can be tested
>
> as for picking up the fix, let's ask Andrew ...
> -mike

Ping?

Andrew, Arnd, could one of you pick this up?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/