Re: [PATCH] ext2: Avoid WARN() messages when failing to write tothe superblock

[Pavel Machek]

On Tue 2009-10-20 01:22:26, Theodore Ts'o wrote:
> This fixes a common warning reported by kerneloops.org
> 

> +static void ext2_clear_super_error(struct super_block * sb)
> +{
> +	struct buffer_head *sbh = EXT2_SB(sb)->s_sbh;
> +
> +	if (buffer_write_io_error(sbh)) {
> +		/*
> +		 * Oh, dear.  A previous attempt to write the
> +		 * superblock failed.  This could happen because the
> +		 * USB device was yanked out.  Or it could happen to
> +		 * be a transient write error and maybe the block will
> +		 * be remapped.  Nothing we can do but to retry the
> +		 * write and hope for the best.
> +		 */
> +		printk(KERN_ERR "EXT2-fs: %s previous I/O error to "
> +		       "superblock detected", sb->s_id);

KERN_ALERT/KERN_CRITICAL?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/