Re: [PATCH tip/core/rcu 6/6] rcu: Simplify creating of lockdepclass for root rcu_node

From: Paul E. McKenney
Date: Mon Oct 26 2009 - 13:29:31 EST


On Mon, Oct 26, 2009 at 07:50:07AM +0100, Ingo Molnar wrote:
>
> * Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
>
> > From: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> >
> > Use lockdep_set_class() to simplify the code and to avoid any additional
> > overhead in the !LOCKDEP case.
> >
> > Signed-off-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
>
> This signoff order is wrong - first signoff line must be the author of
> the patch. (which is a pretty general rule with only rare exceptions)
>
> This patch was from Peter originally, right? In such cases please add:
>
> From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>
> To the head of the patch. Or, if Peter acked it, add:
>
> Acked-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>
> SOB lines are strictly only added by people who send patches to you -
> i.e. it records the patch handling pathway.

I will resubmit with this fixed up, apologies for my confusion.

Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/