Re: [RFC V2 PATCH 5/5] cfq-iosched: fairness for sync no-idle queues

[Corrado Zoccolo]

On Mon, Oct 26, 2009 at 4:45 PM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
> Corrado Zoccolo <czoccolo@xxxxxxxxx> writes:
>
>> +static enum wl_type_t cfqq_type(struct cfq_queue *cfqq)
>> +{
>> + Â Â if (!cfq_cfqq_sync(cfqq))
>> + Â Â Â Â Â Â return ASYNC_WORKLOAD;
>> + Â Â if (CFQQ_SEEKY(cfqq) || !cfq_cfqq_idle_window(cfqq))
>> + Â Â Â Â Â Â return SYNC_NOIDLE_WORKLOAD;
>> + Â Â return SYNC_WORKLOAD;
>> +}
>
> The calculation to determine whether or not to idle is now done in at
> least 2 places. ÂPerhaps it's time for a helper function.

Maybe that CFQQ_SEEKY(cfqq) test can just be removed, and we just rely
on the idle flag set by cfq_update_idle_window (it is already testing
seekiness there, but it also considers number of samples).
I'll do some testing without it to see if it changes anything.

>
> There are some other coding style nits, but I'll let Jens comment on
> those. ÂI think the idea looks good. ÂOnce you rebase I'll run some
> tests; this is some really good work!
>
Thanks. Testing on different hardware is always appreciated.

Cheers,
Corrado
> Cheers,
> Jeff
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/