Re: [PATCH] 2.6.32-rc5 bug in Palm Tungsten C keyboard

[Eric Miao]

On Tue, Oct 27, 2009 at 6:59 AM, Ondrej Zajicek <santiago@xxxxxxxxxxxxx> wrote:
> Palm Tungsten C keyboard structure has swapped
> rows/cols gpio structures and does not work.
> This patch fixes it.
>
> Signed-off-by: Ondrej Zajicek <santiago@xxxxxxxxxxxxx>

This fix looks obvious to me. Applied to 'fix'.

>
> diff -uprN linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c
> --- linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c   2009-10-16 02:41:50.000000000 +0200
> +++ linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c 2009-10-26 20:56:44.000000000 +0100
> @@ -292,10 +292,10 @@ const static unsigned int palmtc_keypad_
>
> Âstatic struct matrix_keypad_platform_data palmtc_keypad_platform_data = {
>    Â.keymap_data  Â= &palmtc_keymap_data,
> -    .col_gpios   Â= palmtc_keypad_row_gpios,
> - Â Â Â .num_col_gpios Â= 12,
> -    .row_gpios   Â= palmtc_keypad_col_gpios,
> - Â Â Â .num_row_gpios Â= 4,
> +    .row_gpios   Â= palmtc_keypad_row_gpios,
> + Â Â Â .num_row_gpios Â= ARRAY_SIZE(palmtc_keypad_row_gpios),
> +    .col_gpios   Â= palmtc_keypad_col_gpios,
> + Â Â Â .num_col_gpios Â= ARRAY_SIZE(palmtc_keypad_col_gpios),
>    Â.active_low   = 1,
>
>    Â.debounce_ms      Â= 20,
>
>
> --
> Elen sila lumenn' omentielvo
>
> Ondrej 'SanTiago' Zajicek (email: santiago@xxxxxxxxxxxxx)
> OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
> "To err is human -- to blame it on a computer is even more so."
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/