Re: staging/dream: add gpio and pmem support

From: Greg KH
Date: Wed Oct 28 2009 - 18:14:43 EST


On Wed, Oct 28, 2009 at 10:56:12PM +0100, Pavel Machek wrote:
>
> > > > With this patch, will it build properly?
> > >
> > > Its certainly way closer to building... it builds for me, with
> > > something like below; platform devices really are initialized from
> > > board-* files and get passed parameters.
> >
> > Ick. This isn't ok, we can't take patches for staging stuff in files
> > outside of drivers/staging/
>
> I know, I was trying to show that ammount of required changes is very small.
>
> > So for now, I've deleted the drivers/staging/dream/ directory from my
> > tree, which will get pushed for 2.6.33. Please clean the code up and
> > get it into buildable shape and I will be glad to add the drivers back
> > into the staging directory at that time.
>
> Ok, I got something that builds; verifying it on device is hard, as
> last kernel that boots there is 2.6.29...
>
> Should I turn it into series and submit?

Yes please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/